Repository navigation
[MINOR][INFRA] Fix coverage badge publish + measure real (e2e) Rust coverage - #62
Closed
HyukjinKwon wants to merge 1 commit into
Closed
HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
…adges` The coverage job's "Create/update badges branch" step aborts on master with: error: The following untracked working tree files would be overwritten by checkout: coverage-rust.json The Rust llvm-cov report was written to coverage-rust.json in the working tree, but coverage-rust.json is ALSO the badge file tracked at the root of the badges branch (the shields.io endpoint the README reads). So when the step does `git checkout badges`, git refuses to overwrite the untracked report with the branch's tracked badge, and the publish fails. Write the raw llvm-cov report to coverage-rust-llvm.json instead (updating the parser to read it). The badge published to the badges branch is still coverage-rust.json, so the README endpoint is unchanged; there is simply no longer a colliding untracked file at checkout time. Co-authored-by: Isaac <no-reply@databricks.com>
HyukjinKwon
changed the title
git checkout badges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Two fixes to the coverage workflow:
Stop the badges publish from aborting. The Rust llvm-cov report was
written to
coverage-rust.json, which is also the badge file tracked at theroot of the
badgesbranch.git checkout badgesthen refused to overwritethe untracked report ("untracked working tree files would be overwritten:
coverage-rust.json") and the publish failed on master. The report is now
coverage-rust-llvm.json; the badge committed to thebadgesbranch is stillcoverage-rust.json, so the README endpoint URL is unchanged.Measure the real Rust coverage. The job ran
cargo llvm-covwith no Sparkserver, so the crate's behavioral e2e tests (
tests/e2e_*.rs), which self-gateon
SPARK_REMOTE, were skipped - collapsing the badge to unit-only (~73%)though the true line coverage is ~90%. Start a Spark 4.2.0 Connect server
(JDK 17 + the downloaded dist + Python worker deps, mirroring
build_python_connect.yml) and run llvm-cov withSPARK_REMOTE=sc://localhost:15002so the e2e suite runs and counts.Why are the changes needed?
The badges publish step failed on every master push, and the Rust badge
under-reported coverage as ~73% (unit-only) instead of the real ~90%.
Does this PR introduce any user-facing change?
No (CI badge publishing only).
How was this patch tested?
The publish step runs only on a master push (verified on merge). The e2e
coverage path mirrors the parity job's server setup, which is exercised on this
PR's own CI. The 0.0% badge-parser bug was fixed separately (already on master).
This pull request and its description were written by Isaac.