Fix race condition in StandardContext.getServletContext()#994
Open
dsoumis wants to merge 1 commit intoapache:mainfrom
Open
Fix race condition in StandardContext.getServletContext()#994dsoumis wants to merge 1 commit intoapache:mainfrom
dsoumis wants to merge 1 commit intoapache:mainfrom
Conversation
The context field was not volatile and getServletContext()was not synchronized, allowing concurrent threads to create competing ApplicationContext instances during reload. This could cause the TEMPDIR servlet context attribute to be permanently lost.
Contributor
|
Ok, I think it makes sense. No need to add weird tests after fixing though, you might as well testing the pattern itself in a generic way at some point. |
Member
Author
|
I think the test adds value to the commit as it acts both as a reproducer and as a resource for anyone inspecting the commit to seamlessly understand what was wrong and fixed. I would keep it if no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context field was not volatile and getServletContext()was not synchronized, allowing concurrent threads to create competing ApplicationContext instances during reload. This could cause the TEMPDIR servlet context attribute to be permanently lost.