Skip to content

Cover that the CLI actually builds the core cache #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apiology wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Cover that the CLI actually builds the core cache #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55a1bfb
Fix crash in solargraph gems core
apiology Sep 6, 2026
e3a4c8b
Restore the example this replaced
apiology Sep 6, 2026
dcdf387
Merge castwide master, keep the core-cache spec
apiology Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions spec/shell_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,14 @@ def bundle_exec(*cmd)
expect { shell.cache('core') }.not_to raise_error
end

it 'caches core pins' do
allow(Solargraph::Collection::Core).to receive(:load).and_return([])

capture_both { shell.cache('core') }

expect(Solargraph::Collection::Core).to have_received(:load)
end

it 'gives sensible error for gem that does not exist' do
skip 'WIP'
output = capture_both do
Expand Down
Loading