Skip to content

add claude plugin banner#2989

Merged
atharvadeosthale merged 1 commit intomainfrom
promo/claude-plugin
Apr 21, 2026
Merged

add claude plugin banner#2989
atharvadeosthale merged 1 commit intomainfrom
promo/claude-plugin

Conversation

@atharvadeosthale
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 21, 2026

Greptile Summary

This PR adds a promotional banner for the Appwrite Claude Code plugin, wiring up a new BottomModalAlertItem (cloud-only, free plan) with a skipUpgradeRedirect flag to prevent free-plan users from being bounced to the upgrade page when clicking the announcement CTA.

  • P1 — Mobile CTA label: The mobile expanded-modal button text is controlled by the outer shouldShowUpgrade (line 178), which does not check skipUpgradeRedirect. Free-plan users on mobile will see "Upgrade plan" instead of "Read announcement" on the Claude plugin banner — the suggestion on bottomModalAlert.svelte line 409 covers the fix.

Confidence Score: 4/5

Safe to merge after fixing the mobile CTA label bug for free-plan users.

One P1 defect: the mobile expanded-modal button shows "Upgrade plan" instead of the intended "Read announcement" for free-plan users because skipUpgradeRedirect is not consulted when computing the button label on mobile. All other changes are correct and minimal.

src/lib/components/bottomModalAlert.svelte — mobile CTA label logic around line 409.

Important Files Changed

Filename Overview
src/lib/components/bottomModalAlert.svelte Adds skipUpgradeRedirect guard in triggerWindowLink and optional-chains $project/$organization; mobile button label still uses the unguarded shouldShowUpgrade, causing incorrect "Upgrade plan" text for free-plan users on the Claude promo banner.
src/lib/stores/bottom-alerts.ts Adds optional skipUpgradeRedirect flag to BottomModalAlertAction type — clean, minimal change.
src/routes/(console)/bottomAlerts.ts Registers the Claude Code plugin promo banner (cloud-only, free plan, importance 8, skipUpgradeRedirect: true, hideOnClick: true) and populates addBottomModalAlerts.
src/lib/images/promos/claude-code-plugin.png New promo image added for the Claude Code plugin announcement banner.

Comments Outside Diff (1)

  1. src/lib/components/bottomModalAlert.svelte, line 409-411 (link)

    P1 Mobile CTA label ignores skipUpgradeRedirect

    The outer shouldShowUpgrade (line 178) is derived from canUpgrade(...) alone, without checking alertAction.skipUpgradeRedirect. For a free-plan user who can upgrade, the mobile button will display "Upgrade plan" instead of "Read announcement" for the Claude plugin promo — even though clicking it will correctly navigate to the announcement URL (because triggerWindowLink now guards against the redirect). The desktop path avoids this because it renders currentModalAlert.cta.text directly; only the mobile expanded-modal path is affected.

Reviews (1): Last reviewed commit: "add claude plugin banner" | Re-trigger Greptile

@atharvadeosthale atharvadeosthale merged commit 95e6625 into main Apr 21, 2026
3 of 4 checks passed
@atharvadeosthale atharvadeosthale deleted the promo/claude-plugin branch April 21, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants