You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a promotional banner for the Appwrite Claude Code plugin, wiring up a new BottomModalAlertItem (cloud-only, free plan) with a skipUpgradeRedirect flag to prevent free-plan users from being bounced to the upgrade page when clicking the announcement CTA.
P1 — Mobile CTA label: The mobile expanded-modal button text is controlled by the outer shouldShowUpgrade (line 178), which does not check skipUpgradeRedirect. Free-plan users on mobile will see "Upgrade plan" instead of "Read announcement" on the Claude plugin banner — the suggestion on bottomModalAlert.svelte line 409 covers the fix.
Confidence Score: 4/5
Safe to merge after fixing the mobile CTA label bug for free-plan users.
One P1 defect: the mobile expanded-modal button shows "Upgrade plan" instead of the intended "Read announcement" for free-plan users because skipUpgradeRedirect is not consulted when computing the button label on mobile. All other changes are correct and minimal.
src/lib/components/bottomModalAlert.svelte — mobile CTA label logic around line 409.
Important Files Changed
Filename
Overview
src/lib/components/bottomModalAlert.svelte
Adds skipUpgradeRedirect guard in triggerWindowLink and optional-chains $project/$organization; mobile button label still uses the unguarded shouldShowUpgrade, causing incorrect "Upgrade plan" text for free-plan users on the Claude promo banner.
src/lib/stores/bottom-alerts.ts
Adds optional skipUpgradeRedirect flag to BottomModalAlertAction type — clean, minimal change.
src/routes/(console)/bottomAlerts.ts
Registers the Claude Code plugin promo banner (cloud-only, free plan, importance 8, skipUpgradeRedirect: true, hideOnClick: true) and populates addBottomModalAlerts.
src/lib/images/promos/claude-code-plugin.png
New promo image added for the Claude Code plugin announcement banner.
Comments Outside Diff (1)
src/lib/components/bottomModalAlert.svelte, line 409-411 (link)
Mobile CTA label ignores skipUpgradeRedirect
The outer shouldShowUpgrade (line 178) is derived from canUpgrade(...) alone, without checking alertAction.skipUpgradeRedirect. For a free-plan user who can upgrade, the mobile button will display "Upgrade plan" instead of "Read announcement" for the Claude plugin promo — even though clicking it will correctly navigate to the announcement URL (because triggerWindowLink now guards against the redirect). The desktop path avoids this because it renders currentModalAlert.cta.text directly; only the mobile expanded-modal path is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.