Skip to content

🔨 A tiny refactoring#159

Merged
arafune merged 23 commits into
mainfrom
refacotre_plugins
Mar 24, 2026
Merged

🔨 A tiny refactoring#159
arafune merged 23 commits into
mainfrom
refacotre_plugins

Conversation

@arafune

@arafune arafune commented Dec 24, 2025

Copy link
Copy Markdown
Owner

Tiny refactoring for prodigy_itx.py

@codecov

codecov Bot commented Dec 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.75439% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.23%. Comparing base (ddca473) to head (ae63318).

Files with missing lines Patch % Lines
src/arpes/utilities/conversion/api.py 58.97% 29 Missing and 3 partials ⚠️
src/arpes/plotting/utils.py 33.33% 5 Missing and 1 partial ⚠️
src/arpes/utilities/conversion/coordinates.py 90.00% 4 Missing and 1 partial ⚠️
src/arpes/analysis/forward_conversion.py 40.00% 3 Missing ⚠️
src/arpes/models/band.py 40.00% 3 Missing ⚠️
src/arpes/analysis/pocket.py 0.00% 1 Missing ⚠️
src/arpes/endstations/fits_utils.py 50.00% 1 Missing ⚠️
tests/test_analysis_general.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   72.08%   72.23%   +0.15%     
==========================================
  Files         226      228       +2     
  Lines       14633    14667      +34     
  Branches     1221     1218       -3     
==========================================
+ Hits        10548    10595      +47     
+ Misses       3853     3843      -10     
+ Partials      232      229       -3     
Flag Coverage Δ
unittests 72.23% <81.75%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arafune

arafune commented Mar 24, 2026

Copy link
Copy Markdown
Owner Author

Summary

This PR refactors the k-space conversion stack and applies a broad cleanup across related utilities, docs,
and tests.

What changed

  • moved convert_to_kspace out of utilities.conversion.core into utilities.conversion.api
  • split lower-level coordinate conversion responsibilities into more focused modules
  • updated package exports and API references to match the new conversion entry point
  • cleaned up analysis and accessor utilities, including _bin behavior and meshgrid-related helpers
  • improved plotting utilities, especially colorbar removal behavior
  • applied Ruff- and typing-driven fixes across analysis, fitting, plotting, conversion, and loader code
  • updated tests to reflect the refactors and adjusted a few expected numeric values
  • refreshed documentation links, Sphinx configuration, API docs, and changelog scaffolding
  • migrated uv development dependencies to dependency groups

Notes

Most of the changes are structural and maintenance-oriented, but they also improve API clarity around
momentum-space conversion and reduce documentation/test noise.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@arafune arafune merged commit 72ca734 into main Mar 24, 2026
4 of 8 checks passed
@arafune arafune deleted the refacotre_plugins branch March 24, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant