✅ Stabilize Gaussian+Fermi fit with normalized input and tuned parameters#162
Open
mkopciuszynski wants to merge 1 commit into
Open
✅ Stabilize Gaussian+Fermi fit with normalized input and tuned parameters#162mkopciuszynski wants to merge 1 commit into
mkopciuszynski wants to merge 1 commit into
Conversation
…l params Normalize test data (phi axis) and update starting parameters for AffineBroadenedFD model to improve convergence and reduce flaky failures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 72.22% 72.22%
=======================================
Files 228 228
Lines 14662 14664 +2
Branches 1223 1223
=======================================
+ Hits 10589 10591 +2
Misses 3843 3843
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky tests by normalizing input data and improving initial fit parameters.
This should stabilize convergence of the AffineBroadenedFD model and removes
intermittent test failures caused by sensitivity to scaling and initialization.