Repository navigation
docs: fix Manager parent class in README example - #578
Open
jasonfigueroa wants to merge 1 commit into
Open
jasonfigueroa wants to merge 1 commit into
jasonfigueroa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401.
The README's
Managerexample does not compile when copied alongside theEmployeeTypeexample. It referencesManagerType, a private nested class, callsBonusSizeas a method, declares the bonus asstringinstead ofdecimal, and assigns to an undefined_bonusSize_field.Use the public
EmployeeTypefor the stored value andTryFromNamelookup. Initialize the value toEmployeeType.Managerso callers can read the properties immediately. ExposeBonusSizeas a read-onlydecimalproperty.Verification used a standalone .NET 10 console project that compiled the README snippets against the local SmartEnum source. Successive builds reproduced these compiler errors:
CS0246for the unresolvedManagerTypereference.CS0122after qualifying the private type asEmployeeType.ManagerType.CS1955for callingBonusSizeas a method.CS0029for returningdecimalthrough astringproperty.CS0103for the undefined_bonusSize_field.The corrected example compiled and passed runtime checks. A new instance returned Manager with a bonus of
10000. SettingTypeto"assistant"resolved Assistant with a bonus of1000. An unknown name threw the expected exception and preserved the previous selection.