Skip to content

feat(experimental): allow binding target facts to project parameters - #558

Merged
awphi merged 7 commits into
mainfrom
configure-with-facts
Oct 29, 2026
Merged

awphi merged 7 commits into
mainfrom
configure-with-facts

Conversation

@awphi

@awphi awphi commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Changes

x-topo:
  parameters:
    TARGET_MEMORY_KB:
      description: Physical memory on the deployment target
      source:
        provider: topo.memory
        group: system-memory
        fact: memory.total
  • This allows for some basic level of target-aware configuration of a project without introducing a fragile name-based parameter contract.
  • Warns if you configure a project that attempts to bind to target facts and you don't have a target set. Instead you'll just be asked for a value in the interactive resolver.
  • No docs or schema changes while this remains experimental!

Checklist

  • 🤖 This change is covered by tests as required.
  • 🤹 All required manual testing has been performed.
  • 📖 All documentation updates are complete.

Stack created with GitHub Stacks CLI • Give Feedback 💬

@awphi
awphi added this pull request to stack #559 October 26, 2026 15:40
@awphi
awphi force-pushed the configure-with-facts branch from b53a7be to 668b42e Compare October 26, 2026 15:58
Comment thread cmd/topo/configure.go Resolved
@awphi
awphi marked this pull request as ready for review October 27, 2026 10:57
@awphi
awphi requested a review from a team as a code owner October 27, 2026 10:57
@awphi
awphi force-pushed the configure-with-facts branch from d480c0c to 3b30d70 Compare October 27, 2026 13:51
Base automatically changed from facts to main October 27, 2026 14:41
@awphi
awphi force-pushed the configure-with-facts branch from 3b30d70 to e7e449c Compare October 27, 2026 14:41
@awphi
awphi force-pushed the configure-with-facts branch from e7e449c to ab87f25 Compare October 28, 2026 10:32
awphi added 4 commits October 28, 2026 11:23
Signed-off-by: awphi <adam.hodson@arm.com>
Signed-off-by: awphi <adam.hodson@arm.com>
Signed-off-by: awphi <adam.hodson@arm.com>
@awphi
awphi force-pushed the configure-with-facts branch from ab87f25 to a04c9ad Compare October 28, 2026 11:25
Comment thread cmd/topo/configure.go Resolved
Comment thread internal/fact/fact.go Resolved
Signed-off-by: awphi <adam.hodson@arm.com>
awphi added 2 commits October 29, 2026 10:56
Signed-off-by: awphi <adam.hodson@arm.com>
Signed-off-by: awphi <adam.hodson@arm.com>

@yejseo01 yejseo01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awphi
awphi merged commit fb73e71 into main Oct 29, 2026
5 checks passed
@awphi
awphi deleted the configure-with-facts branch October 29, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants