Skip to content

Use line lists from locally-installed PypeIt if available - #326

Merged
hpparvi merged 2 commits into
astropy:mainfrom
cgobat:pypeit-line-loading
Oct 20, 2026
Merged

hpparvi merged 2 commits into
astropy:mainfrom
cgobat:pypeit-line-loading

Conversation

@cgobat

@cgobat cgobat commented Oct 9, 2026

Copy link
Copy Markdown
Member

Falls back to the current behavior (direct download from GitHub) if it can't find pypeit locally.

Resolves #292

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.54%. Comparing base (4e330bc) to head (2262eff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   92.52%   92.54%   +0.02%     
==========================================
  Files          18       18              
  Lines        2341     2348       +7     
==========================================
+ Hits         2166     2173       +7     
  Misses        175      175              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hpparvi

hpparvi commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Thanks @cgobat, this looks all good to me! I'll be happy to merge the PR if you still first revise the changelog.

@hpparvi hpparvi added this to the v1.10 milestone Oct 18, 2026
@hpparvi

hpparvi commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Thanks, merged!

@hpparvi
hpparvi merged commit 70f83d5 into astropy:main Oct 20, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wishlist]: Read calibration data from pypeit instead of downloading it

2 participants