Security: Internal error details and stack traces are returned to API clients#2145
Open
tomaioo wants to merge 1 commit intoasyncapi:masterfrom
Open
Conversation
The global problem handler serializes 5xx errors with `includeStack: true` and `includeCause: true`, then returns them in JSON responses. This can expose internal implementation details (stack traces, dependency paths, error causes), which helps attackers with reconnaissance and exploit development. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
tomaioo
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Internal error details and stack traces are returned to API clients
Problem
Severity:
High| File:src/apps/api/middlewares/problem.middleware.ts:L31The global problem handler serializes 5xx errors with
includeStack: trueandincludeCause: true, then returns them in JSON responses. This can expose internal implementation details (stack traces, dependency paths, error causes), which helps attackers with reconnaissance and exploit development.Solution
Do not include stack traces or causes in client-facing responses by default. Gate verbose error output behind a strict development-only check (e.g.,
NODE_ENV === 'development'), and always return sanitized generic messages in production.Changes
src/apps/api/middlewares/problem.middleware.ts(modified)