Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Change VCS toggle keybind#456

Open
lee-dohm wants to merge 1 commit intomasterfrom
ld-change-vcs-toggle-keybind
Open

Change VCS toggle keybind#456
lee-dohm wants to merge 1 commit intomasterfrom
ld-change-vcs-toggle-keybind

Conversation

@lee-dohm
Copy link
Copy Markdown
Contributor

Applies to #455

Changes the keybinding from I to Cmd/Ctrl+I.

@izuzak
Copy link
Copy Markdown
Contributor

izuzak commented May 29, 2015

How exactly does this help resolve #455? The exact keybinding doesn't seem like the problem here.

@lee-dohm
Copy link
Copy Markdown
Contributor Author

It doesn't actually resolve #455. But this change is related to that Issue in that it was suggested as a means of making the accidental activation of the command more rare. @kevinsawicki brought it up on Slack and I wrote up the Issue and this PR to get the discussion going.

@izuzak
Copy link
Copy Markdown
Contributor

izuzak commented May 29, 2015

Thanks for explaining, @lee-dohm. I'm concerned that this change will 1) annoy users who are used to the existing keybinding (I'm pretty used to it myself), and 2) not actually solve the problem. I'd be 👍 on waiting with this change until we've explored other options, since the problem itself doesn't affect that many users.

Also, can I talk you into extending the description in #455 with 🔗 to issues or discussion where this problem was reported?

@lee-dohm
Copy link
Copy Markdown
Contributor Author

I'd be 👍 on waiting with this change until we've explored other options

Agreed.

Also, can I talk you into extending the description in #455 with 🔗 to issues or discussion where this problem was reported?

Sure thing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants