fix: coerce str prompts to Prompt in exemplar selectors#77
Open
finitearth wants to merge 1 commit into
Open
Conversation
timo282
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select_exemplarsaccepted a rawstrprompt in practice but passed it straight totask.evaluate, which turned the string into a list of single characters vialist(prompts)and later crashed withAttributeError: 'str' object has no attribute 'construct_prompt'(after running predictions on every character first — hence the misleading "fails after many runs").str -> Promptat the selector boundary in bothRandomSelectorandRandomSearchSelector, mirroring how optimizers coerceinitial_promptsinBaseOptimizer.__init__.task.evaluatestays strict (Prompt-only).BaseExemplarSelector.select_exemplarstype hint toUnion[str, Prompt].Test plan
respects_n_examples,accepts_str_prompt,n_examples_kwarg) over bothRandomSelectorandRandomSearchSelectorstrprompt is coerced rather than split into characters🤖 Generated with Claude Code