Fix TestEpochRebroadcastsEmptyVoteAfterBlockProposalReceived Flake #419
Merged
Conversation
samliok
force-pushed
the
flake-rebroadcast
branch
from
755fd1b to
1a593f8
Compare
yacovm
reviewed
Jun 22, 2026
A single time advance can produce duplicate empty-vote broadcasts: the proposal-timeout vote and the timeout-handler's rebroadcast on the same tick. Two tests assumed exactly one empty vote would be observed. - waitForEmptyVote now drains duplicate rebroadcasts before returning so callers' require.Len(comm.emptyVotes, 0) is not racy. - TestEpochNoFinalizationAfterEmptyVote now tolerates duplicate empty votes before the notarization instead of asserting a fixed position.
Forming the empty notarization advances the node to round 4, where it is the leader and asynchronously proposes and persists a round 4 block. That trailing block record races with the test's wal.ReadAll(), so the empty vote and notarization are not reliably the last two records. Locate the empty vote and empty notarization records by type instead of assuming fixed positions at the end of the WAL.
…l race This test reads the WAL assuming the round 4 block proposal is the last record, but that proposal is persisted asynchronously after the empty notarization advances the node to round 4. Wait for the proposal to be persisted (AssertBlockProposal) before the positional read so it is deterministically present.
samliok
changed the title
yacovm
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.