Repository navigation
Add material_precedence to make material groups mutually exclusive - #344
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gpeairs
left a comment
There was a problem hiding this comment.
This seems pretty generally useful, not just for an imported solid -- could really reduce the need for juggling volumes in postrendering.
That said, I would suggest making a regular operation that just does set differences, like ("vacuum", exclude_groups, ("vacuum", ["substrate", "bump_extrusion"]). Then apply_precedence (names are just illustrative, call these what you like) can be a function that generates a list of those operations, which can be splatted into wherever it's needed, like into #346's post_fragment_ops. This also makes it more friendly for eventual integration with #328.
Thanks, good call. Done! |
a076077 to
cafb862
Compare
gpeairs
left a comment
There was a problem hiding this comment.
LGTM, just take care of the merge conflict. Thanks!
cafb862 to
3cf6237
Compare
Split out of #331.
After fragmentation an entity can belong to several material groups (e.g. both
chipandvacuum).partition_material_groups!keeps each entity only in its highest-priority listed group. Exposed asmaterial_precedenceonrender!,render_conformal!(requiresfragment_backstop=true), andSolidModelTarget.