Skip to content

Fast calculation of curvilinear contour orientation - #357

Merged
gpeairs merged 5 commits into
mainfrom
gp/curvilinear-orientation
Nov 2, 2026
Merged

gpeairs merged 5 commits into
mainfrom
gp/curvilinear-orientation

Conversation

@gpeairs

@gpeairs gpeairs commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

#353 normalized curvilinear contour orientation for correctness, but calculates it by discretization, which is slow. This PR adds a fast calculation of orientation (via signed area) for curvilinear contours.

@gpeairs
gpeairs requested a review from laylagi October 29, 2026 10:51
Comment thread src/curvilinear.jl Resolved
Comment thread src/curvilinear.jl Resolved
@gpeairs
gpeairs force-pushed the gp/curvilinear-orientation branch from e47fd6b to 185ad04 Compare November 1, 2026 18:23
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gpeairs

gpeairs commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

Made the changes above. I also changed a few unrelated test lines to get the test suite running quiet again.

@gpeairs
gpeairs requested a review from laylagi November 2, 2026 11:27

@laylagi laylagi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good!

@gpeairs
gpeairs merged commit 900e196 into main Nov 2, 2026
11 checks passed
@gpeairs
gpeairs deleted the gp/curvilinear-orientation branch November 2, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants