Repository navigation
Fix placement, transformation, and bounds of 1D entities - #359
Merged
Merged
Conversation
LineSegments could not be placed in a coordinate system of a different
coordinate type (no convert method to GeometryEntity{T}), transform(::D1, f)
called a nonexistent parametric constructor, so placing one through a
reference threw a MethodError, and their bounds fell back to an empty
polygon list and returned a zero rectangle at the origin.
Rebuild D1 entities with their unparameterized constructor in transform,
add convert(::Type{GeometryEntity{T}}, ::D1), and define lowerleft and
upperright for LineSegment so bounds (including of styled segments) give
its extent. Add tests and a CHANGELOG entry.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gpeairs
approved these changes
Oct 29, 2026
gpeairs
left a comment
Member
There was a problem hiding this comment.
Looks good, I'm just going to apply one minor suggestion myself and then merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
transformandconvertmethods to 1D geometry entities to ensure that they can be properly placed onto coordinate systems and transformed. Also addslowerleftandupperrighttoLineSegmentso that its bounds can be extracted.