Repository navigation
Return false from isapprox on Point arrays of different sizes - #374
Merged
Merged
Conversation
zip stopped at the shorter array, so only the common prefix was compared and an empty array was approximately equal to any other.
Name Polygon in the CHANGELOG entry.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isapproxon arrays ofPoints compared elements pairwise withzip, which stops at the shorter array, so only the common prefix was checked:Now arrays of different sizes compare
false, like==, instead of throwingDimensionMismatchlike Base's arrayisapprox.isapproxonPolygons uses this method, so polygons with different numbers of vertices are no longer approximately equal when one's vertices are a prefix of the other's.The elementwise tolerance is unchanged. Removing this method in favor of Base's norm-based array
isapproxis part of GH#300 (#49) for 2.0.Not breaking: this fixes silently incorrect results.