Skip to content

Nest solid model selection metadata under "selections" - #377

Merged
gpeairs merged 1 commit into
mainfrom
arrangop/sm-metadata-schema
Nov 12, 2026
Merged

gpeairs merged 1 commit into
mainfrom
arrangop/sm-metadata-schema

Conversation

@parrangoiz

@parrangoiz parrangoiz commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Following up on a comment I made in #328 , this moves the "tagged", "ports", "terminals", and "ground" sections of the metadata generated in SolidModelsExperimental into a new top-level "selections" object. This will keep the file tidier as new selection types are introduced.

I'm not bumping the schema version since this feature is not yet in use. Also, should we just include this in the next patch release since this is all experimental?

Move the "tagged", "ports", "terminals", and "ground" sections of the
SolidModelsExperimental metadata from the top level into a new top-level
"selections" object. The schema now requires "selections" with exactly
those four keys (always present, possibly empty); schema_version stays
1.0.0 since the format is unreleased. The serializer, the
SingleTransmonExperimental configfile, the tests, and the metadata
example in the concepts docs are updated to the nested layout.
@parrangoiz
parrangoiz requested a review from gpeairs November 10, 2026 22:44
@parrangoiz parrangoiz changed the title Nest solid-model selection metadata under "selections" Nest solid model selection metadata under "selections" Nov 10, 2026
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gpeairs gpeairs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good as is. I'll cut a patch version soon.

@gpeairs
gpeairs merged commit f673ab3 into main Nov 12, 2026
11 checks passed
@gpeairs
gpeairs deleted the arrangop/sm-metadata-schema branch November 12, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants