Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the 1.x part of #7.
render!accepts arbitrary keyword arguments so that options can reachto_polygonsmethods andOptionalStyles, but that means a typo likeatoll=0.1nmorsimulaton=trueis silently ignored. This PR makes the top-levelrender!methods warn about any keyword argument that isn't a known rendering option:render!method declares are never reported. The other known options are the ones built-in rendering reads (atol,rtol,Δθ,map_meta, and thesimulation/artwork/solidmodelflags), plus the flags of everyOptionalStyleconstructed so far, which register themselves.DeviceLayout.register_render_kwarg!.strict=:warnfails on it.SolidModels.populate_size_fields!checks its keywords the same way, and its warning names it.This is a warning rather than an error for now. Making unknown options an error, or replacing the keywords with an options struct, is left for 2.0 (#300). The
render!→place!path for coordinate systems (#275) is unchanged.Notes:
zmapwhen rendering to aCell) does warn, since it has no effect there.OptionalStyleat top level should callregister_render_kwarg!for its flag in__init__, since registrations made during precompilation aren't kept.fine_mesh=truewas meant to be thefinemeshflag of anOptionalStyledefined in the same test, so the fine-mesh branch was never exercised. Fixed, and the assertion that accepted either mesh size now requires the fine one.