Repository navigation
fix sparse-in-dense deser for maps - #729
Merged
Merged
Conversation
wty-Bryant
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originally we retained the key w/ zero value, in schema-serde (and in original legacy codegen cbor) we instead errored, but we are seeing a handful of impact in downstream sdk so we are reverting to old behavior for now
the null handling actually goes in the generated dispatcher for deserializing maps, so the only runtime fix needed was in the httpbinding deserializer
added kitchensink tests in the sdk for both schema-serde and legacy json/cbor to validate this