fix: use official io.floci:spring-boot-testcontainers-floci - #1701
fix: use official io.floci:spring-boot-testcontainers-floci#1701Mendred wants to merge 1 commit into
Conversation
…f re-implementing it Removes AwsFlociContainerConnectionDetailsFactory and FlociAwsClientFactory, which duplicated the ContainerConnectionDetailsFactory<FlociContainer, AwsConnectionDetails> already provided by io.floci:spring-boot-testcontainers-floci. Having both implementations on the classpath at the same time breaks Spring Boot's service connection resolution (two competing factories for the same pair), as reported by the Floci maintainer in awspring#1604. Depend on io.floci:spring-boot-testcontainers-floci (optional, same scope as before) instead of the low-level io.floci:testcontainers-floci module. This also brings automatic S3 path-style configuration for Floci, which the removed implementation was missing. Ref: awspring#1604 Ref: https://github.com/floci-io/testcontainers-floci
|
For convenience, I'll mention here what I have already shared in #1604:
|
|
Hey @Mendred , I appreciate quick PR! However I am closing this PR check comment -> #1604 (comment) |
Removes AwsFlociContainerConnectionDetailsFactory and FlociAwsClientFactory, which duplicated the ContainerConnectionDetailsFactory<FlociContainer, AwsConnectionDetails> already provided by io.floci:spring-boot-testcontainers-floci. Having both implementations on the classpath at the same time breaks Spring Boot's service connection resolution (two competing factories for the same pair), as reported by the Floci maintainer in #1604.
Depend on io.floci:spring-boot-testcontainers-floci (optional, same scope as before) instead of the low-level io.floci:testcontainers-floci module. This also brings automatic S3 path-style configuration for Floci, which the removed implementation was missing.
Ref: #1604 (comment)
Ref: https://github.com/floci-io/testcontainers-floci
📢 Type of change
📜 Description
Removed my testcontainers-floci implementation (AwsFlociContainerConnectionDetailsFactory and FlociAwsClientFactory) in favour of the official io.floci:spring-boot-testcontainers-floci module.
spring-cloud-aws-testcontainers now depends on io.floci:spring-boot-testcontainers-floci (optional, same scope as before) instead of the low-level io.floci:testcontainers-floci module. This removes the duplicated ContainerConnectionDetailsFactory<FlociContainer, AwsConnectionDetails> and, as a side effect, also brings automatic S3 path-style configuration for Floci, which our own implementation was missing.
💡 Motivation and Context
see #1604 (comment)
💚 How did you test it?
JUnit Test
📝 Checklist
🔮 Next steps