Use floci/floci image in Docker Compose documentation - #1702
Open
hectorvent wants to merge 1 commit into
Open
Conversation
The Floci example in the Docker Compose reference documentation used `hectorvent/floci`, a personal Docker Hub account image. AwsDockerComposeConnectionDetailsFactory only recognizes services whose image matches localstack/localstack, localstack/localstack-pro or floci/floci, so a compose file copied from the documentation starts a container that is never detected and no AwsConnectionDetails are contributed. Use the canonical floci/floci image, consistent with the image already used by docker-compose-floci.yaml in the module tests.
hectorvent
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
September 9, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Floci example in
docs/src/main/asciidoc/docker-compose.adocreferenced thehectorvent/flociimage, which is a personal Docker Hub account image. This changes it to the canonicalfloci/flociimage.💡 Motivation and Context
AwsDockerComposeConnectionDetailsFactorymatches services by image name against a fixed list (AWS_EMULATOR_CONTAINER_NAMES):localstack/localstack,localstack/localstack-proandfloci/floci.Because
hectorvent/flociis not in that list, a compose file copied from the documentation starts a container that Spring Cloud AWS never detects: noAwsConnectionDetailsare contributed and the application silently falls back to the default AWS endpoints instead of the local emulator.The correct image name is already used everywhere else in the project, including the test fixture
docker-compose-floci.yamland the Testcontainers tests.💚 How did you test it?
Documentation-only change, no production code touched.
AwsDockerComposeConnectionDetailsFactory#AWS_EMULATOR_CONTAINER_NAMES, which is the condition the example was failing.spring-cloud-aws-docker-compose/src/test/resources/docker-compose-floci.yaml, which already usesfloci/flociand is exercised byAwsDockerComposeConnectionDetailsFactoryTest.spring-cloud-aws-docker-composemodule tests locally: 10 tests, all passing, includingAwsDockerComposeConnectionDetailsFactoryTest$FlociTests.📝 Checklist
AwsDockerComposeConnectionDetailsFactoryTest$FlociTestsalready coversfloci/flocidetection🔮 Next steps
None.