Skip to content

Use floci/floci image in Docker Compose documentation - #1702

Open
hectorvent wants to merge 1 commit into
awspring:mainfrom
hectorvent:docs-floci-image-name
Open

Use floci/floci image in Docker Compose documentation#1702
hectorvent wants to merge 1 commit into
awspring:mainfrom
hectorvent:docs-floci-image-name

Conversation

@hectorvent

Copy link
Copy Markdown

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The Floci example in docs/src/main/asciidoc/docker-compose.adoc referenced the hectorvent/floci image, which is a personal Docker Hub account image. This changes it to the canonical floci/floci image.

💡 Motivation and Context

AwsDockerComposeConnectionDetailsFactory matches services by image name against a fixed list (AWS_EMULATOR_CONTAINER_NAMES): localstack/localstack, localstack/localstack-pro and floci/floci.

Because hectorvent/floci is not in that list, a compose file copied from the documentation starts a container that Spring Cloud AWS never detects: no AwsConnectionDetails are contributed and the application silently falls back to the default AWS endpoints instead of the local emulator.

The correct image name is already used everywhere else in the project, including the test fixture docker-compose-floci.yaml and the Testcontainers tests.

💚 How did you test it?

Documentation-only change, no production code touched.

  • Verified the documented image now matches an entry in AwsDockerComposeConnectionDetailsFactory#AWS_EMULATOR_CONTAINER_NAMES, which is the condition the example was failing.
  • Cross-checked against the existing fixture spring-cloud-aws-docker-compose/src/test/resources/docker-compose-floci.yaml, which already uses floci/floci and is exercised by AwsDockerComposeConnectionDetailsFactoryTest.
  • Ran the spring-cloud-aws-docker-compose module tests locally: 10 tests, all passing, including AwsDockerComposeConnectionDetailsFactoryTest$FlociTests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes — documentation-only change; AwsDockerComposeConnectionDetailsFactoryTest$FlociTests already covers floci/floci detection
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

None.

The Floci example in the Docker Compose reference documentation used
`hectorvent/floci`, a personal Docker Hub account image.

AwsDockerComposeConnectionDetailsFactory only recognizes services whose
image matches localstack/localstack, localstack/localstack-pro or
floci/floci, so a compose file copied from the documentation starts a
container that is never detected and no AwsConnectionDetails are
contributed.

Use the canonical floci/floci image, consistent with the image already
used by docker-compose-floci.yaml in the module tests.
@github-actions github-actions Bot added the type: documentation Documentation or Samples related issue label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation Documentation or Samples related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant