Skip to content

Refactor assertion logger to avoid deprecation warnings in Pharo 13 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcotelli merged 4 commits into from
Apr 7, 2026
Merged

Refactor assertion logger to avoid deprecation warnings in Pharo 13 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dcc207
Refactor LoggingAsserter
gcotelli Apr 6, 2026
bc077ef
Add missing method on GS64 MemoryLogger
gcotelli Apr 6, 2026
ea1c212
Add extension for Pharo 10, 11 & 12 to avoid deprecation warnings in …
gcotelli Apr 6, 2026
9ac3387
Fix baseline
gcotelli Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions source/BaselineOfBell/BaselineOfBell.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
Class {
#name : #BaselineOfBell,
#superclass : #BaselineOf,
#category : #BaselineOfBell
#name : 'BaselineOfBell',
#superclass : 'BaselineOf',
#category : 'BaselineOfBell',
#package : 'BaselineOfBell'
}

{ #category : #baselines }
{ #category : 'baselines' }
BaselineOfBell >> baseline: spec [

<baseline>
Expand All @@ -19,15 +20,15 @@ BaselineOfBell >> baseline: spec [
group: 'default' with: 'Development' ]
]

{ #category : #baselines }
{ #category : 'baselines' }
BaselineOfBell >> setUpDependencies: spec [

spec
baseline: 'NeoJSON' with: [ spec repository: 'github://ba-st-dependencies/NeoJSON:v20' ];
project: 'NeoJSON-Deployment' copyFrom: 'NeoJSON' with: [ spec loads: 'Deployment' ].
]

{ #category : #baselines }
{ #category : 'baselines' }
BaselineOfBell >> setUpDeploymentPackages: spec [

spec
Expand All @@ -36,7 +37,7 @@ BaselineOfBell >> setUpDeploymentPackages: spec [

]

{ #category : #baselines }
{ #category : 'baselines' }
BaselineOfBell >> setUpPackages: spec [

self
Expand All @@ -46,19 +47,24 @@ BaselineOfBell >> setUpPackages: spec [

]

{ #category : #initialization }
{ #category : 'initialization' }
BaselineOfBell >> setUpSUnitPackages: spec [

spec
package: 'Bell-SUnit' with: [ spec requires: #( 'Bell-Logging' ) ];
group: 'Dependent-SUnit-Extensions' with: 'Bell-SUnit'
spec
package: 'Bell-SUnit' with: [ spec requires: #( 'Bell-Logging' ) ];
group: 'Dependent-SUnit-Extensions' with: 'Bell-SUnit'.
spec for: #( #'pharo10.x' #'pharo11.x' #'pharo12.x' ) do: [
spec
package: 'Bell-Pharo-10-Extensions';
group: 'Dependent-SUnit-Extensions' with: 'Bell-Pharo-10-Extensions'
]
]

{ #category : #baselines }
{ #category : 'baselines' }
BaselineOfBell >> setUpTestPackages: spec [

spec
package: 'Bell-Logging-Tests'
with: [ spec requires: #( 'Bell-Logging' 'Bell-SUnit' ) ];
group: 'Tests' with: 'Bell-Logging-Tests'.
spec
package: 'Bell-Logging-Tests'
with: [ spec requires: #( 'Bell-Logging' 'Dependent-SUnit-Extensions' ) ];
group: 'Tests' with: 'Bell-Logging-Tests'
]
2 changes: 1 addition & 1 deletion source/BaselineOfBell/package.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Package { #name : #BaselineOfBell }
Package { #name : 'BaselineOfBell' }
6 changes: 6 additions & 0 deletions source/Beacon-GS64/MemoryLogger.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ MemoryLogger >> announcer [
^ announcer
]

{ #category : #accessing }
MemoryLogger >> entries [

^ self recordings
]

{ #category : #initialization }
MemoryLogger >> initialize [
super initialize.
Expand Down
7 changes: 7 additions & 0 deletions source/Bell-Pharo-10-Extensions/MemoryLogger.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Extension { #name : 'MemoryLogger' }

{ #category : '*Bell-Pharo-10-Extensions' }
MemoryLogger >> entries [

^ self recordings
]
1 change: 1 addition & 0 deletions source/Bell-Pharo-10-Extensions/package.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Package { #name : 'Bell-Pharo-10-Extensions' }
15 changes: 11 additions & 4 deletions source/Bell-SUnit/LoggingAsserter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ LoggingAsserter class >> on: aTestCase [
{ #category : 'asserting' }
LoggingAsserter >> assertLogRecordsMatch: anExpectedLogEntryCollection [

memoryLogger recordings with: anExpectedLogEntryCollection do: [ :record :expectedLogEntry |
testCase assert: ( record printString includesSubstring: expectedLogEntry ) ]
self logRecords with: anExpectedLogEntryCollection do: [ :record :expectedLogEntry |
testCase assert: ( record printString includesSubstring: expectedLogEntry ) ]
]

{ #category : 'asserting' }
LoggingAsserter >> assertLogRecordsMatchUsing: aRegexCollection [

memoryLogger recordings with: aRegexCollection do: [ :record :regexExpression |
self logRecords with: aRegexCollection do: [ :record :regexExpression |
testCase
assert: ( record printString matchesRegex: regexExpression )
description:
Expand All @@ -47,6 +47,12 @@ LoggingAsserter >> initializeOn: aTestCase [
testCase := aTestCase
]

{ #category : 'accessing' }
LoggingAsserter >> logRecords [

^ memoryLogger entries
]

{ #category : 'running' }
LoggingAsserter >> runMemoryLoggerDuring: aBlockClosure [

Expand All @@ -56,5 +62,6 @@ LoggingAsserter >> runMemoryLoggerDuring: aBlockClosure [
{ #category : 'running' }
LoggingAsserter >> stopLoggers [

memoryLogger reset
memoryLogger reset.
MemoryLogger resetInstance
]
Loading