Skip to content

Require kamal-proxy 0.10.2 or higher - #1960

Open
jeremy wants to merge 1 commit into
mainfrom
kamal-proxy-0.10.2
Open

jeremy wants to merge 1 commit into
mainfrom
kamal-proxy-0.10.2

Conversation

@jeremy

@jeremy jeremy commented Oct 6, 2026

Copy link
Copy Markdown
Member

Raise the default and minimum kamal-proxy version from v0.9.2 to v0.10.2.

v0.9.2 is inside the affected range of two published kamal-proxy advisories:

Kamal boots MINIMUM_VERSION unless proxy.run.version is set, so a default setup keeps running an affected proxy until the pin moves.

Same shape as the v0.9.2 bump in f9ffc11: the constant, the tests that hardcode the image tag, and the image the integration setup seeds into the local registry.

Upgrading

As with earlier bumps, kamal deploy checks the version of the running proxy and stops on hosts that are older:

kamal-proxy version v0.9.2 is too old, run `kamal proxy reboot` in order to update to at least v0.10.2

Run kamal proxy reboot (or kamal proxy reboot --rolling) once per deployment to move to v0.10.2. A reboot interrupts traffic briefly on each host. Apps that pin proxy.run.version need to raise it to v0.10.2 or later first.

v0.10.2 adds client timeouts to the public listeners, on by default: 10s for request headers and TLS handshakes, 60s for idle keep-alive connections, and 60s between reads of a request body. The body timeout restarts whenever more data arrives, so uploads that keep making progress are not cut off.

Tests

  • bin/test test/commands/proxy_test.rb test/cli/proxy_test.rb test/configuration/proxy*: 84 runs, 0 failures.
  • Full unit suite: same result as main (8 local failures in both, from Docker-backed build tests and the local git email).
  • bin/test test/integration (Docker): 17 runs, 0 failures. It deploys with v0.10.2 pulled from the local registry and checks the running proxy image.

@jeremy
jeremy requested review from djmb and a balanced review from Copilot October 6, 2026 19:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T19:30:56.787221Z 6781850 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants