Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the default and minimum kamal-proxy version from v0.9.2 to v0.10.2.
v0.9.2 is inside the affected range of two published kamal-proxy advisories:
Kamal boots
MINIMUM_VERSIONunlessproxy.run.versionis set, so a default setup keeps running an affected proxy until the pin moves.Same shape as the v0.9.2 bump in f9ffc11: the constant, the tests that hardcode the image tag, and the image the integration setup seeds into the local registry.
Upgrading
As with earlier bumps,
kamal deploychecks the version of the running proxy and stops on hosts that are older:Run
kamal proxy reboot(orkamal proxy reboot --rolling) once per deployment to move to v0.10.2. A reboot interrupts traffic briefly on each host. Apps that pinproxy.run.versionneed to raise it to v0.10.2 or later first.v0.10.2 adds client timeouts to the public listeners, on by default: 10s for request headers and TLS handshakes, 60s for idle keep-alive connections, and 60s between reads of a request body. The body timeout restarts whenever more data arrives, so uploads that keep making progress are not cut off.
Tests
bin/test test/commands/proxy_test.rb test/cli/proxy_test.rb test/configuration/proxy*: 84 runs, 0 failures.main(8 local failures in both, from Docker-backed build tests and the local git email).bin/test test/integration(Docker): 17 runs, 0 failures. It deploys with v0.10.2 pulled from the local registry and checks the running proxy image.