Repository navigation
fix(apt): mark deb_import repos reproducible - #279
Open
kevinpark1217 wants to merge 1 commit into
Open
kevinpark1217 wants to merge 1 commit into
kevinpark1217 wants to merge 1 commit into
Conversation
Return repo_metadata(reproducible = True) so deb_import repos enter Bazel's repo contents cache, and fail when the linker-script grep errors so a bad scan is never cached. Fixes bazel-contrib#277
Author
|
@thesayyn Hello! Would it be possible to get a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277.
deb_importnow returnsrctx.repo_metadata(reproducible = True), so its repos enter Bazel's repo contents cache (8.3+) and a fresh output base reuses them instead of re-fetching every.deb. Thehasattrguard makes it a no-op on older Bazel.The linker-script
grepnow fails on exit code > 1. Before this, agreperror silently dropped the--remap-inputs, and now that result would be cached.Test
bazel test //...passes on 8.5.1.libbsd-devfor the linker-script path) on 8.5.1 with two fresh output bases sharing one--repo_contents_cache: everydeb_importrepo in both is a symlink to the same cache entry, and libbsd's remap is intact.