fix: allows developers to provide a block pool to argon2#1647
Closed
shawkins wants to merge 2 commits intobcgit:mainfrom
Closed
fix: allows developers to provide a block pool to argon2#1647shawkins wants to merge 2 commits intobcgit:mainfrom
shawkins wants to merge 2 commits intobcgit:mainfrom
Conversation
closes: bcgit#1646 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Author
|
@jill-kleiber @dghgit Rebased this. Please let me know if there is any interest in this, or if it should just be abandoned. |
Collaborator
|
We're currently in the process of publishing our PQC work. One that's wrapped up I'll have a look at this. |
Contributor
|
Thanks for the patch, this has been added with a minor revision and some tests (moved the block pool definitions). Now in https://www.bouncycastle.org/betas Apologies for the delay. |
hubot
pushed a commit
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1646
Provides a way for developers to reuse memory for argon2. Assumes that the implementation will call allocate / deallocate in pairs - no checking is done for multiple deallocation.
If you are open to this approach, what kind of tests would you like to see for this?
cc @ahus1 @vmuzikar