Consuming iteration, #65.#66
Merged
Merged
Conversation
becheran
approved these changes
Jun 17, 2025
becheran
left a comment
becheran
left a comment
Owner
There was a problem hiding this comment.
Looks good. Thank you for adding tests
Owner
|
I am not sure hey the pipelines are red. Night also be a ci issue. Will have a deeper Look into it once I am back home |
Contributor
Author
Should work now, please rerun |
Contributor
Author
|
but the last broken check is not from my code, perhaps version of clippy changed or something? |
Contributor
Author
|
I will bump the lowest supported rust version to pass the check. Weird it worked before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by popular demand (me) implement #65