Skip to content

feat: add prepend_rows and prepend_cols#67

Merged
becheran merged 3 commits into
becheran:masterfrom
mario-holubar:prepending
Jul 29, 2025
Merged

feat: add prepend_rows and prepend_cols#67
becheran merged 3 commits into
becheran:masterfrom
mario-holubar:prepending

Conversation

@mario-holubar

Copy link
Copy Markdown
Contributor

Building on #64, I added functionality to expand grids in the other direction.

Should probably rename either these or the expand_* functions as they don't match now.
I like prepend / append as they convey directionality, but they also kind of imply insertion of data rather than just resizing.
Alternatively something like expand_rows_before could work.
Thoughts?

@becheran becheran left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Just Remote the commented Code sections please.

Comment thread src/lib.rs Outdated
@mario-holubar mario-holubar requested a review from becheran July 25, 2025 11:06

@becheran becheran left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@becheran becheran merged commit 80e96ff into becheran:master Jul 29, 2025
5 checks passed
@mario-holubar mario-holubar deleted the prepending branch July 29, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants