Repository navigation
fix: panic when parsing proxies with remote dns - #276
Merged
Hidden character warning
The head ref may contain hidden characters: "beck-8/panic-\u5904\u7406"
Merged
Conversation
mihomo's dns.ParseNameServer is a function variable assigned only in mihomo/config's init(). subs-check didn't import that package, so wireguard/masque/openvpn/zerotier proxies with remote-dns-resolve and dns crashed in adapter.ParseProxy with a nil pointer dereference. Import mihomo/config for its init(), and parse the custom DNS config with mihomo's parser instead of the hand-written one, which also fixes bare IPv6 nameservers being parsed without a port. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
TestUploadToS3 needs a local MinIO, so it failed `go test ./...` anywhere else. Gate it behind the minio_it build tag, like the substore_it integration tests, so the default test run can pass in CI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
beck-8
changed the title
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.