Repository navigation
update: continue when an item or album can't be moved (#2419) - #7076
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7076 +/- ##
==========================================
- Coverage 80.49% 80.49% -0.01%
==========================================
Files 149 149
Lines 21248 21255 +7
Branches 3282 3282
==========================================
+ Hits 17104 17109 +5
- Misses 3315 3316 +1
- Partials 829 830 +1
🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @snejus, just checking in on this one. All checks are green and the changelog is synced with master. Happy to adjust anything if you’d like a different approach. |
Serene-Arc
approved these changes
Oct 15, 2026
snejus
requested changes
Oct 21, 2026
Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
Contributor
Author
|
Applied, thanks for the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2419.
beet update -mused to stop on the first file it couldn't move, so everything after it was left half-updated in the DB (album record still had the old name, files not moved). Now aFilesystemErrorduring a move gets logged and the update keeps going with the rest, like suggested in the issue.updatepicks it up again and retries. Same pattern as the existingReadErrorhandling right above it.FilesystemErroris caught, so anything else still surfaces.Added two regression tests, one for albums and one for singletons. Both fail without the fix and pass with it. Left
beet move(#1926) out of this PR to keep it small, happy to look at it on its own.AI disclosure: I used Claude Code to help write the code, tests and changelog entry. I reproduced the bug on current master, decided the approach and scope (following the discussion in the issue), had the fix extended to the item loop after reviewing the first version, and verified everything with the tests and the repro. Happy to explain or rework any part of it.
To Do
Documentation.