Skip to content

deezer: store track rank instead of 1 in deezerupdate - #7110

Open
williamo123 wants to merge 1 commit into
beetbox:masterfrom
williamo123:fix-deezer-rank
Open

williamo123 wants to merge 1 commit into
beetbox:masterfrom
williamo123:fix-deezer-rank

Conversation

@williamo123

Copy link
Copy Markdown

Description

Fixes #7106 .

deezerupdate saved deezer_track_rank = 1 for every track on line 282 of beetsplug/deezer.py see the misplaced parenthesis wrapping the whole comparison previous to this change.

Tested using the reproduction steps from #7106.

To Do

  • [ x] Documentation. N/A
  • [ x] Changelog.
  • Tests. test_deezer.py does not cover deezerupdate although I would be glad to add one if required.

@williamo123
williamo123 requested a review from a team as a code owner October 22, 2026 13:42
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.50%. Comparing base (50f6d62) to head (0f34185).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
beetsplug/deezer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7110      +/-   ##
==========================================
- Coverage   80.68%   80.50%   -0.18%     
==========================================
  Files         149      149              
  Lines       21241    21241              
  Branches     3281     3281              
==========================================
- Hits        17139    17101      -38     
- Misses       3271     3311      +40     
+ Partials      831      829       -2     
Files with missing lines Coverage Δ
beetsplug/deezer.py 46.05% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

beet deezerupdate is supposed to store each track's Deezer rank in deezer_track_rank but it stores 1 for every track

1 participant