Repository navigation
Return nil for negative child removal indices - #161
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
RemoveChildAt(-1)currently panics, although its documented contract returns nil when the index is out of bounds.Check the lower bound before indexing the child slice. Add regressions for negative and upper bounds on empty elements and elements with several token types.
The tests check that invalid calls preserve child identity, order, parents, indices and serialized XML.
The native suite, race coverage, vet and build pass on Go 1.23.4 and 1.27.0 on Linux amd64.
Commands:
go test -v ./...,go test -race -cover ./...,go vet ./...andgo build -v ./....All 12 new cases pass. Six negative index cases fail against the original source.