Skip to content

Do not count optional Stratum setup rejections as shares#1707

Closed
0xjc65eth wants to merge 1 commit into
bitaxeorg:masterfrom
0xjc65eth:fix-ignore-optional-stratum-errors
Closed

Do not count optional Stratum setup rejections as shares#1707
0xjc65eth wants to merge 1 commit into
bitaxeorg:masterfrom
0xjc65eth:fix-ignore-optional-stratum-errors

Conversation

@0xjc65eth

@0xjc65eth 0xjc65eth commented May 25, 2026

Copy link
Copy Markdown

Summary

  • track the request IDs used for optional Stratum V1 setup calls after authorization
  • handle mining.suggest_difficulty and mining.extranonce.subscribe responses separately from share submit responses
  • prevent optional setup rejections such as Method not found from being reported as rejected shares

Why

Some pools do not implement optional Stratum V1 methods and can return Method not found. Those responses are setup capability rejections, not share submit failures, so they should not pollute rejected share stats or dashboard rejection reasons.

Fixes #1383.

Testing

  • git diff --check

Full firmware build was not run locally because idf.py is not installed in this shell and the Docker daemon is not running (/var/run/docker.sock is unavailable).

@0xjc65eth

Copy link
Copy Markdown
Author

Closing this for now to reduce maintainer review load, per feedback from @mutatrum. I am keeping #1705 open as the single focused PR because it is small, UI-only, and already has an ack. Happy to revisit this later only if maintainers ask for it. Thanks for the feedback and for maintaining the project.

@0xjc65eth 0xjc65eth closed this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter out Method not found on failed setup messages as rejected share reasons

1 participant