Fix work received notification with SV2#1778
Open
mutatrum wants to merge 3 commits into
Open
Conversation
mutatrum
force-pushed
the
sv2-work-received
branch
from
29d9f60 to
f9f1906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work received notification on the dashboard (the green down arrow on the Block Header card) was triggered when the scriptSig changes. This never happens on SV1 Standard Channel, and only occasionally on SV2 Extended Channel. This changes the trigger to use the work received counter, similar to how the notification on the display works.
It also splits out the share accepted and rejected notification into a green up arrow and a red cross.