Skip to content

Feature/v3#42

Merged
notmandatory merged 5 commits into
bitcoindevkit:mainfrom
AminaBank:feature/v3
May 21, 2026
Merged

Feature/v3#42
notmandatory merged 5 commits into
bitcoindevkit:mainfrom
AminaBank:feature/v3

Conversation

@ulrichard

Copy link
Copy Markdown
Collaborator

upgrading to bdk_wallet v3.0

@ulrichard ulrichard force-pushed the feature/v3 branch 5 times, most recently from c2a4c7b to c4b075f Compare May 19, 2026 12:22
@ulrichard ulrichard requested a review from notmandatory May 19, 2026 13:46
@ulrichard ulrichard marked this pull request as ready for review May 19, 2026 13:48

@notmandatory notmandatory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to 3.0! Overall looks good but have one question about the new error checks.

Sorry I haven't gotten the prior version bumps reviewed, after this PR goes in do you need #40 and #41 reviewed or can close them?

Comment thread src/reserves.rs Outdated
Comment thread src/reserves.rs Outdated

@notmandatory notmandatory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c8a5cb5

Thanks!

@notmandatory

Copy link
Copy Markdown
Member

Should we make a new tag and publish a release for these changes?

@notmandatory notmandatory merged commit c8a5cb5 into bitcoindevkit:main May 21, 2026
3 checks passed
@notmandatory notmandatory mentioned this pull request May 21, 2026
@ulrichard

Copy link
Copy Markdown
Collaborator Author

@notmandatory thanks for merging. I just tagged and published to crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants