Skip to content

Fixed Key Bindings bug on MacOS IINA - #248

Open
reddiedev wants to merge 1 commit into
bloc97:masterfrom
reddiedev:master
Open

reddiedev wants to merge 1 commit into
bloc97:masterfrom
reddiedev:master

Conversation

@reddiedev

Copy link
Copy Markdown

Problem

After following the Instructions for IINA to install Anime4k on IINA, the key binds would not work (no output on OSD or on IINA logs). However, when I was trying it with mpv (and using the same config directory), the commands for Anime4k worked.

Root Cause

Ultimately, I don't think this is due to Anime4k's installation method, but rather due to how IINA registers the key bindings in the active configuration file. I am not sure of any way to fix it from within Anime4k, so I am sharing the fix i found below.

Workaround

I followed the workaround from below and added the guide on how to implement on the install instructions for MacOS/IINA

Please refer to the original IINA issue for context

@Tama47

Tama47 commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

I don't think this is due to Anime4k's installation method, but rather due to how IINA registers the key bindings in the active configuration file.

Correct! I haven't used IINA in a while, but unless something has changed, I remember that mpv key bindings do work with IINA when I originally made the guide.

And thanks for the fix! Would you mind exporting the new config file for IINA and have users download that instead? Just so that it would be easier and more straightforward than to have IINA users manually duplicate and create a new config file themselves.

@Sharelter

Copy link
Copy Markdown

Thanks for the fix! I think it's very helpful

@yorkyang2333

Copy link
Copy Markdown

If you're looking for an easier way, I put together a dedicated IINA plugin that automates the Anime4K installation with a simple double-click:
https://github.com/yorkyang233/iina-anime4k
Hope it helps!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants