Feature/spinner control

README.md

@@ -21,6 +21,7 @@
 
   <h3 align="center">Just Another Workout Timer</h3>
 
+
   <p align="center">
     A simple timer for your workouts, built with Flutter!
     <br />

lib/l10n/intl_en.arb

@@ -57,7 +57,9 @@
     "settingHalfway": "Play sound or announcement halfway during exercise",
     "settings": "Settings",
     "soundOutput": "Sound output",
+    "spinnerStep": "Editor time granularity",
     "startWorkout": "Start workout",
+    "tapToEdit": "Tap to edit",
     "title": "Just Another Workout Timer",
     "tts": "Text-to-Speech (TTS)",
     "ttsLang": "TTS Language",

lib/layouts/settings_page.dart

@@ -102,6 +102,35 @@ class SettingsPageState extends State<SettingsPage> {
             subtitle: Text(S.of(context).expanded_setlist_info),
             pref: 'expanded_setlist',
           ),
+
+          PrefTitle(
+            title: Text(
+              S.of(context).editWorkout,
+            ),
+          ),
+          PrefDropdown<int>(
+            title: Text(S.of(context).spinnerStep),
+            pref: 'spinner_step',
+            items: [
+              DropdownMenuItem(
+                value: 5,
+                child: Text("5 ${S.of(context).seconds}"),
+              ),
+              DropdownMenuItem(
+                value: 10,
+                child: Text("10 ${S.of(context).seconds}"),
+              ),
+              DropdownMenuItem(
+                value: 15,
+                child: Text("15 ${S.of(context).seconds}"),
+              ),
+            ],
+          ),
+          PrefSwitch(
+            title: Text(S.of(context).tapToEdit),
+            pref: 'tap_to_edit',
+          ),
+
           PrefTitle(
             title: Text(
               S.of(context).backup,

lib/layouts/workout_builder.dart

@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:fluttertoast/fluttertoast.dart';
+import 'package:prefs/prefs.dart';
 import 'package:uuid/uuid.dart';
 
 import '../generated/l10n.dart';
@@ -196,7 +197,9 @@ class BuilderPageState extends State<BuilderPage> {
                     lowerLimit: 1,
                     upperLimit: 99,
                     largeSteps: false,
+                    step: 1,
                     formatNumber: false,
+                    tapToEdit: false,
                     value: set.repetitions,
                     valueChanged: (repetitions) {
                       setState(() {
@@ -337,7 +340,9 @@ class BuilderPageState extends State<BuilderPage> {
                     lowerLimit: 0,
                     upperLimit: 10800,
                     largeSteps: true,
+                    step: Prefs.getInt('spinner_step', 10) ,
                     formatNumber: true,
+                    tapToEdit: Prefs.getBool('tap_to_edit', false),
                     value: _workout.sets[setIndex].exercises[exIndex].duration,
                     valueChanged: (duration) {
                       setState(() {

lib/main.dart

@@ -31,6 +31,8 @@ void main() async {
       'tts_next_announce': true,
       'sound': 'tts',
       'expanded_setlist': false,
+      'spinner_step': 10,
+      'tap_to_edit' : false,
     },
   ).then(
     (service) => Future.wait([

lib/utils/number_stepper.dart

@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter/rendering.dart';
 import 'package:flutter/services.dart';
 import 'package:numberpicker/numberpicker.dart';
 
@@ -16,6 +17,8 @@ class NumberStepper extends StatefulWidget {
     required this.valueChanged,
     required this.formatNumber,
     required this.largeSteps,
+    required this.step,
+    required this.tapToEdit,
   });
 
   final int lowerLimit;
@@ -24,20 +27,26 @@ class NumberStepper extends StatefulWidget {
   int value;
   final ValueChanged<int> valueChanged;
   final bool formatNumber;
+  // if false, shows a number with plus/minus buttons.
+  // if true, shows the spinner.
   final bool largeSteps;
+  final int step;
+  final bool tapToEdit;
 
   @override
   CustomStepperState createState() => CustomStepperState();
 }
 
 class CustomStepperState extends State<NumberStepper> {
   bool _isEditingText = false;
+  bool _isSpinnerActive = true;
   late TextEditingController _editingController;
 
   @override
   void initState() {
     super.initState();
     _editingController = TextEditingController(text: widget.value.toString());
+    _isSpinnerActive = !widget.tapToEdit;
   }
 
   @override
@@ -47,12 +56,16 @@ class CustomStepperState extends State<NumberStepper> {
   }
 
   Widget _editableTextField() {
-    if (_isEditingText) {
+    var isSpinnerValid = widget.value % widget.step == 0;
+
+    if (_isEditingText || !isSpinnerValid) {
       _editingController.value =
           TextEditingValue(text: widget.value.toString());
-      return Center(
+      return Container(
+        width: 122,
+        alignment: Alignment.centerRight,
         child: SizedBox(
-          width: 112,
+          width: 75,
           child: TextField(
             maxLines: 1,
             maxLengthEnforcement: MaxLengthEnforcement.enforced,
@@ -75,35 +88,64 @@ class CustomStepperState extends State<NumberStepper> {
                 }
               });
             },
-            autofocus: true,
+            // Only autofocus if we're text editing, not for isSpinnerValid
+            autofocus: _isEditingText,
             controller: _editingController,
-            decoration: InputDecoration(suffixText: S.of(context).seconds),
+            decoration: InputDecoration(
+              helperText: S.of(context).seconds,
+              helperStyle: const TextStyle(fontSize: 14),
+            ),
           ),
         ),
       );
     }
     return InkWell(
       onTap: () {
         setState(() {
-          _isEditingText = true;
+          if (widget.tapToEdit) {
+            _isSpinnerActive = true;
+          }
+          else {
+            _isEditingText = true;
+          }
+        });
+      },
+      onLongPress: () {
+        setState(() {
+          if (widget.tapToEdit) {
+            _isEditingText = true;
+          }
         });
       },
-      child: NumberPicker(
-        itemHeight: 32,
-        value: widget.value,
-        minValue: widget.lowerLimit,
-        step: 10,
-        itemCount: 3,
-        haptics: true,
-        zeroPad: false,
-        maxValue: widget.upperLimit,
-        textMapper: (value) => Utils.formatSeconds(int.parse(value)),
-        onChanged: (value) {
-          setState(() {
-            widget.value = value;
-            widget.valueChanged(value);
-          });
-        },
+      child: IgnorePointer(
+        ignoring: !_isSpinnerActive,
+        child: NotificationListener<UserScrollNotification>(
+          onNotification: (notification) {
+            setState(() {
+              if (notification.direction == ScrollDirection.idle && widget.tapToEdit) {
+                _isSpinnerActive = false;
+              }
+            });
+            return true;
+          },
+          child: NumberPicker(
+            itemHeight: 32,
+            value: widget.value,
+            minValue: widget.lowerLimit,
+            step: widget.step,
+            itemCount: 3,
+            haptics: true,
+            zeroPad: false,
+            maxValue: widget.upperLimit,
+            textMapper: (value) => Utils.formatSeconds(int.parse(value)),
+            onChanged: (value) {
+              setState(() {
+                widget.value = value;
+                widget.valueChanged(value);
+              });
+            },
+          ),
+        ),
       ),
     );
   }