transport: wire real stream Reset / CancelRead / CancelWrite (finish #40) - #78
Merged
Conversation
) Bumps zquic to v1.7.68 and connects the shim's previously no-op stream cancel stubs to zquic's new raw-app reset API: - `streamCancelWrite` → RESET_STREAM (Go transport `Reset`/`CancelWrite`) - `streamCancelRead` → STOP_SENDING (Go `CancelRead`), releasing our receive obligation / flow-control credit — the peer replies RESET_STREAM - `streamResetReceived` → the peer's application error code if it reset the stream (read side of Go `StreamResetError{Code}`) Both are role-aware (client vs server) and now consume the formerly-dead `Stream.reset_how` as the application error code. The QUIC handshake tests already drive `streamCancelWrite` via `PeerConn.close`; the RESET_STREAM round-trip itself is covered by the zquic loopback test in zigstack/zquic#240. Together with the earlier `ConnectionStats` change, this lands the concrete transport-control features from the Go reference. Refs #40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40. Connects the shim's previously no-op stream-cancel stubs to zquic's new raw-app reset API (ch4r10t33r/zquic#240, v1.7.68), mirroring the Go transport
Reset/CancelRead/CancelWrite.Changes
zquicv1.7.67 → v1.7.68.zquic_quic_shim.streamCancelWrite→ RESET_STREAM (GoReset/CancelWrite).zquic_quic_shim.streamCancelRead→ STOP_SENDING (GoCancelRead) — asks the peer to stop sending, releasing our receive obligation / flow-control credit; the peer replies with RESET_STREAM.zquic_quic_shim.streamResetReceived(st) ?u64→ the peer's application error code if it reset the stream (read side of GoStreamResetError{Code}).Stream.reset_howas the app error code.Coverage
streamCancelWriteviaPeerConn.close(now a real RESET_STREAM) —zig build test-quicgreen.zig build test+zig build test-quicpass on stock 0.16.0. README updated. With the earlierConnectionStatsPR (#77), this lands the concrete transport-control items from the Go reference; datagrams ("not supported yet"upstream too) and stream deadlines (deliberate poll-driven divergence) remain out of scope.