Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Intial Python3 support (requires Twisted>=16)#75

Merged
bmuller merged 6 commits into
bmuller:masterfrom
nocko:python3
Jun 30, 2018
Merged

Intial Python3 support (requires Twisted>=16)#75
bmuller merged 6 commits into
bmuller:masterfrom
nocko:python3

Conversation

@nocko

@nocko nocko commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Removes Spanish support from vendered BermiInflector (the file encoding is all screwed up and it was easier to do so). The right answer to that may be to submodule the upstream in a separate patchset.

Requires Twisted>=16 because thats when twisted.enterprise was ported.

@nocko

nocko commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

Hrm. Tox tests for all 2.7 and 3.5 environments pass on my machine. Maybe travis config needs a tweak?

@coveralls

coveralls commented Oct 27, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling c1ad24c on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

coveralls commented Oct 27, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

6 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

coveralls commented Oct 27, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

coveralls commented Oct 27, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 85.787% when pulling e9c528c on nocko:python3 into 19f4ce3 on bmuller:master.

@coveralls

coveralls commented Oct 27, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 85.925% when pulling a3b2843 on nocko:python3 into 19f4ce3 on bmuller:master.

@bmuller

bmuller commented Oct 31, 2016

Copy link
Copy Markdown
Owner

Thanks @nocko for the code update! I'm going to try to get #74 merged in, and then this one, for a new major release.

@mracter

mracter commented Jun 25, 2018

Copy link
Copy Markdown

Any updates on the status of this feature? Would very much like to use this for a Python3 project, as Python2.7 is no longer supported.

@bmuller

bmuller commented Jun 30, 2018

Copy link
Copy Markdown
Owner

Sorry for the delay on this, @mracter! I'm going to go ahead and merge now while waiting on #74. I'll make a new major release, too.

PS: My old code looks so gross.

@bmuller

bmuller commented Jun 30, 2018

Copy link
Copy Markdown
Owner

And thanks @nocko!

@bmuller bmuller merged commit 0e82b88 into bmuller:master Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants