Repository navigation
Scan hint: a user's own type folder beats the cbz default - #279
Merged
Merged
Conversation
A plain cbz under a user's own Manga/ folder was typed comic by the extension rule before the folder hint was consulted. At scan the order is now: manga flag, then the top-level folder hint, then cbz/cbr -> comic. Imports, auto-import and uploads have no hint and are unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #270. A plain CBZ under a library's own
Manga/folder was typed comic, because the cbz rule ran before the folder hint.At scan the order is now: manga flag (ComicInfo or chapters dir), then the top-level folder hint, then cbz/cbr as comic. Imports, auto-import and uploads have no folder hint and behave as before.
Tests cover a plain CBZ under
Manga/, a manga-flagged CBZ underComics/, and a CBZ under a folder that matches no type.