Repository navigation
npm sucks ! - #286
npm sucks !#286llaumgui wants to merge 2 commits into
Conversation
|
First of all, sorry for the late answer - got work throughout the week and this is a big PR, took some time to look through it and test it. I'm going to pass on the pnpm switch, but I'd like to take the react-resizable change on its own, that's a real fix. What I hit testing it:
Bigger picture: it's one package with 44 deps and installs are already fast, so this is mostly a preference change that touches every contributor's setup. Not against pnpm, just don't see what it improves right now. Happy to revisit if that changes. Want to split the react-resizable line into its own PR? Or I cherry-pick it, whichever you prefer. |
|
Hi, no pb for the time.
I check.
It bypasses the delay for newly released dependencies. In my view, when a zero-day issue occurs, you need to deploy the fix right away without waiting out a cooldown.
Not for me. Perhaps a GH issue?
pnpm is more efficiant add quick than npm. Also, do a big update of all dependencies is very simple: pnpm is more efficient and faster than npm. Also, running a major update on all dependencies is really simple: pnpm update --latest. I'd like to propose (with PR) switching from pip/pip-tools to uv, or do you think that's too big of a change for now? |
|
@bndct-devops you would like a PR just with
Have you try to use vitetest ? I use on my personnal project (https://github.com/llaumgui/seedboxsync) and I have better time than e2e or jest. On a professionnal project I have migrate from e2E to vitest with IA. You remove chrome dependency and win a lot of processing time. |
|
@llaumgui Yes please, a PR with just npm add react-resizable and I'll merge it straight away. On Vitest: they're not interchangeable here. The e2e specs boot the real backend with seeded data and click through the UI, which is what gives us regression coverage for things like the library cleanup flow from #165. Vitest is for unit tests, and dropping the browser would drop what those tests check. The e2e step itself is about 2.5 minutes, the 3h was the Node download, not the tests. One note on the corepack fix in case you reuse it elsewhere: NODE_ENV=production before pnpm install skips devDependencies, and vite and typescript live there, so the build step won't have them. I'd also avoid piping an installer from the web in a Dockerfile. Closing this one, thanks again for the work on it. |
Summary
npm sucks:
;-)
Changes
Move from npm to pnpm and build with matrix (22/24/26) on Github Actions.
Screenshots
N/A
Checklist
pytestpassespnpm run buildclean (frontend typecheck)Notes
N/A