Map google scholar package imports#535
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
|
I checked this locally on Python 3.10. The google scholar mapping resolves as expected, and the normalized local-distribution comparison covers the Checks I ran: All passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google_scholar_pyimports to thescrape-google-scholar-pydistributionserpapiunmapped because PyPI now has an officialserpapipackage; forcing it togoogle-search-resultswould break currentimport serpapiusersAddresses the
google_scholar_pyhalf of #370.Verification
.venv/bin/python -m unittest tests.test_pipreqs.TestPipreqs.test_get_pkg_names_maps_google_scholar tests.test_pipreqs.TestPipreqs.test_get_import_local_matches_normalized_distribution_names tests.test_pipreqs.TestPipreqs.test_get_missing_imports_matches_normalized_distribution_names.venv/bin/python -m unittest discoveruv run --with flake8 flake8 pipreqs testsgit diff --checkreview-fix-loop: clean after fixing reviewer findings