Implement a minimal Fci functionality on master - #629
Open
totork wants to merge 78 commits into
Open
Conversation
Modify Div_par_fvv and Div_par_fvv_heating so that they compile with 3D metrics.
Dataset.hermes.extract_[12]_tokamak_geometry() calls now result in an
error:
```
Traceback (most recent call last):
File "/home/runner/work/hermes-3/hermes-3/build/tests/integrated/2D-recycling/runtest", line 144, in <module>
ds = ds.hermes.extract_2d_tokamak_geometry()
File "/home/runner/.local/lib/python3.10/site-packages/xhermes/accessors.py", line 172, in extract_2d_tokamak_geometry
raise Exception(
Exception: extract_2d_tokamak_geometry was called twice! Note: this is now done automatically upon loading
```
… compile-3dmetric-clean
…ile-3dmetric-clean
totork
marked this pull request as draft
July 29, 2026 10:22
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 57.53% 57.56% +0.02%
==========================================
Files 98 97 -1
Lines 10223 10078 -145
Branches 1466 1459 -7
==========================================
- Hits 5882 5801 -81
+ Misses 3753 3682 -71
- Partials 588 595 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… for parallel derivatives
Latest master
totork
marked this pull request as ready for review
July 29, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fci is currently running on a separate branch. This diverges signifcant effort of us into separate codes. This first PR aims to adjust Hermes-3 to use the Fci implementation of Bout++ that was updated recently.
Change Summary
Mostly changes hidden behind .isFci() - flags. It is mainly preserving parallel slices by using .asField3DParallel() at certain positions where its needed
Validation
Added 3 1-D MMS test (density, momentum & pressure) for Fci that pass, including the CI.
AI Assistance
Nope.
Documentation
Not yet
Review Notes
This branch is forked from
https://github.com/boutproject/hermes-3/tree/compile-3dmetric
so it certainly needs
#577
To do: