Skip to content

ci: ask for another Louise review with the louise:review label - #164

Merged
bowenforsoup merged 2 commits into
mainfrom
ci/review-label
Oct 4, 2026
Merged

bowenforsoup merged 2 commits into
mainfrom
ci/review-label

Conversation

@bowenforsoup

Copy link
Copy Markdown
Member

What changes

The Louise review caller adds labeled to its pull_request types, so the louise:review label asks for another review. The label exists in this repository now.

Merge order

Merge bowenlabs/claude-plugins#24 first. That pull request limits a pull request to two automatic reviews, moves the CI review to Sonnet, and ignores labels other than louise:review. Until it's on main, a labeled event here would start a review for any label.

This pull request is a draft so that opening it doesn't start a review on the current workflow. Mark it ready after #24 merges; that review then runs on Sonnet.

Testing

  • actionlint 1.7.12: clean.

Generated with Claude Code

The reusable review now runs twice per pull request on its own
(bowenlabs/claude-plugins#24). The labeled event lets the louise:review
label ask for another.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
astroidjs 0b03c8e Oct 04 2026, 10:41 PM

…ce on its own

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bowenforsoup
bowenforsoup marked this pull request as ready for review October 4, 2026 22:43
@bowenforsoup
bowenforsoup merged commit fe3222f into main Oct 4, 2026
22 checks passed
@bowenforsoup
bowenforsoup deleted the ci/review-label branch October 4, 2026 22:44
@bowenlabs-louise-agent

Copy link
Copy Markdown

Verdict: Not ready to merge. The labeled trigger depends on claude-plugins#24, but this repository runs the pinned commit a199aa6, and the PR doesn't bump the pin. Merging #24 first doesn't change what runs here.

Findings

1. .github/workflows/louise-review.yml:21: the merge order in the PR body doesn't cover the pin. With the pin unchanged, any label starts a review.

Line 21 still pins @a199aa6387afd6b64548dd3dbdc1d5b206313357. At that commit the reusable workflow skips only drafts, pull requests from forks, and pull requests from other bots. It has no label filter and no cap on automatic reviews. Once this PR is out of draft:

  • Every labeled event runs a full review with the Claude token, the Louise token, and the agent app key, including labels from changesets, Renovate, or agent:*.
  • The cap of two automatic reviews doesn't apply.

That is the risk the PR body says merging #24 first avoids, and merging #24 doesn't avoid it.

2. .github/workflows/louise-review.yml:2-3: the new header comment describes behavior the pinned workflow doesn't have.

"It reviews a pull request on its own at most twice; the louise:review label asks for another" describes #24. At a199aa6 the workflow reviews again on every push and treats all labels alike. The prose passes the style check; it is wrong for the code it ships with.

  • Fix: Land the comment in the same change as the pin bump in finding 1.
  • Source: the same README section at the pinned commit. Also astroidjs CLAUDE.md, "Decisions get an ADR": "A stale ADR is worse than none, because people trust it." That line is about ADRs, but it applies to a header that documents a security boundary.

Style (Vale)

No findings. .louise/vale.txt is empty.

Checked, nothing found

  • Rules: The change adds no louise-toolkit dependency, doesn't touch template/, and changes no package, so it needs no scaffold smoke run and no changeset.
  • Decisions: ADR 0025 (action pins) covers each site's generated release.yml, not this workflow, so it neither conflicts nor needs amending.
  • Design: No UI files changed.

No other repository affected. The change depends on bowenlabs/claude-plugins#24 but doesn't change claude-plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant