Skip to content

[CLOSED] Replace .isResolved & .isRejected with .state #3438

Description

@core-ai-bot

Issue by TuckerWhitehouse
Monday Apr 29, 2013 at 19:55 GMT
Originally opened as adobe/brackets#3665


This is a step towards the eventually upgrade to jQuery 2.0 (#3123).

Both .isResolved & .isRejected were deprecated in jQuery 1.7 and removed in 1.8 (http://api.jquery.com/deferred.isResolved/).


TuckerWhitehouse included the following code: https://github.com/adobe/brackets/pull/3665/commits

Activity

  1. core-ai-bot commented on Aug 29, 2021

    @core-ai-bot
    MemberAuthor

    Comment by TuckerWhitehouse
    Monday Apr 29, 2013 at 20:01 GMT


    Also, should the wiki/Brackets-Coding-Conventions be updated to advise people to use .state instead of .isResolved or .isRejected?

  2. core-ai-bot commented on Aug 29, 2021

    @core-ai-bot
    MemberAuthor

    Comment by jasonsanjose
    Tuesday Apr 30, 2013 at 21:05 GMT


    Reviewing

  3. core-ai-bot commented on Aug 29, 2021

    @core-ai-bot
    MemberAuthor

    Comment by jasonsanjose
    Tuesday Apr 30, 2013 at 21:47 GMT


    @TuckerWhitehouse I don't think we necessarily need a note on the wiki to avoid deprecated or soon-to-be-deprecated APIs. Your changes look good and passes tests. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions