-
Notifications
You must be signed in to change notification settings - Fork 1
Release v1.7.12
#460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.7.12
#460
Changes from all commits
4629664
964fdbe
fe544c2
f39d47d
dc8398a
0348e8c
4f58e1f
6aef224
d3e5923
f361235
79d7198
5cdf637
9f40456
3c5aec8
cfd3dc3
7343d1e
333f63b
db41fdc
5b27cc9
1c222d9
abb5f70
a4306f5
b4701c3
1080460
9d63321
3931f04
c43d5ee
b7cb9fb
4fb0255
7b7bb32
1c877a0
9bcfe1e
8f174df
392943c
c8d1d5a
a1936af
14bf35a
6218a4b
90114e6
6e84818
2e99897
7f390ce
965dcd9
42d8b7f
f43f471
361df05
6725503
ba4a9d8
62671fa
2b28391
1caa4d0
f0d92b7
59e19c6
b106218
2699269
ee91b67
de97445
ae2932a
8c8a943
09a64fc
d7a682c
3bee711
5ad2431
10519a5
0bf4b29
65f6f77
117ac6a
0d6086f
a38d8b2
4f1a9cb
801d8f6
15e3baf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,43 @@ | ||
| name: Claude Code Review | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, ready_for_review, reopened] | ||
| # Optional: Only run on specific file changes | ||
| # paths: | ||
| # - "src/**/*.ts" | ||
| # - "src/**/*.tsx" | ||
| # - "src/**/*.js" | ||
| # - "src/**/*.jsx" | ||
| pull_request: | ||
| types: [opened, synchronize, ready_for_review, reopened] | ||
| # Optional: Only run on specific file changes | ||
| # paths: | ||
| # - "src/**/*.ts" | ||
| # - "src/**/*.tsx" | ||
| # - "src/**/*.js" | ||
| # - "src/**/*.jsx" | ||
|
|
||
| jobs: | ||
| claude-review: | ||
| # Optional: Filter by PR author | ||
| # if: | | ||
| # github.event.pull_request.user.login == 'external-contributor' || | ||
| # github.event.pull_request.user.login == 'new-developer' || | ||
| # github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' | ||
| claude-review: | ||
| # Optional: Filter by PR author | ||
| # if: | | ||
| # github.event.pull_request.user.login == 'external-contributor' || | ||
| # github.event.pull_request.user.login == 'new-developer' || | ||
| # github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' | ||
|
|
||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: read | ||
| id-token: write | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: read | ||
| id-token: write | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Run Claude Code Review | ||
| id: claude-review | ||
| uses: anthropics/claude-code-action@v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
| plugin_marketplaces: 'https://github.com/anthropics/claude-code.git' | ||
| plugins: 'code-review@claude-code-plugins' | ||
| prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}' | ||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||
| # or https://code.claude.com/docs/en/cli-reference for available options | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Run Claude Code Review | ||
| id: claude-review | ||
| uses: anthropics/claude-code-action@v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
| plugin_marketplaces: 'https://github.com/anthropics/claude-code.git' | ||
| plugins: 'code-review@claude-code-plugins' | ||
| prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}' | ||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||
| # or https://code.claude.com/docs/en/cli-reference for available options |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,49 @@ | ||
| name: Claude Code | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| issues: | ||
| types: [opened, assigned] | ||
| pull_request_review: | ||
| types: [submitted] | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| issues: | ||
| types: [opened, assigned] | ||
| pull_request_review: | ||
| types: [submitted] | ||
|
|
||
| jobs: | ||
| claude: | ||
| if: | | ||
| (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) || | ||
| (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude'))) | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: read | ||
| id-token: write | ||
| actions: read # Required for Claude to read CI results on PRs | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
| claude: | ||
| if: | | ||
| (github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) || | ||
| (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude'))) | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: read | ||
| id-token: write | ||
| actions: read # Required for Claude to read CI results on PRs | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Run Claude Code | ||
| id: claude | ||
| uses: anthropics/claude-code-action@v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
| - name: Run Claude Code | ||
| id: claude | ||
| uses: anthropics/claude-code-action@v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
|
|
||
| # This is an optional setting that allows Claude to read CI results on PRs | ||
| additional_permissions: | | ||
| actions: read | ||
| # This is an optional setting that allows Claude to read CI results on PRs | ||
| additional_permissions: | | ||
| actions: read | ||
|
|
||
| # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it. | ||
| # prompt: 'Update the pull request description to include a summary of changes.' | ||
|
|
||
| # Optional: Add claude_args to customize behavior and configuration | ||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||
| # or https://code.claude.com/docs/en/cli-reference for available options | ||
| # claude_args: '--allowed-tools Bash(gh pr:*)' | ||
| # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it. | ||
| # prompt: 'Update the pull request description to include a summary of changes.' | ||
|
|
||
| # Optional: Add claude_args to customize behavior and configuration | ||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||
| # or https://code.claude.com/docs/en/cli-reference for available options | ||
| # claude_args: '--allowed-tools Bash(gh pr:*)' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,56 @@ | ||
| name: Publish Public Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| publish-build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' | ||
|
|
||
| # Build the library | ||
| - name: Install and Build | ||
| run: | | ||
| npm ci | ||
| npm run build | ||
|
|
||
| # Push to public mirror repo | ||
| - name: Push Build to Public Mirror | ||
| env: | ||
| FORCE_UI_TOKEN: ${{ secrets.FORCE_UI_TOKEN }} | ||
| run: | | ||
| # Clone public mirror repo | ||
| git clone https://x-access-token:${{ secrets.FORCE_UI_TOKEN }}@github.com/brainstormforce/bsf-admin-ui.git build-repo | ||
|
|
||
| cd build-repo | ||
|
|
||
| # Clear old dist | ||
| rm -rf dist | ||
|
|
||
| # Copy new build | ||
| cp -r ../dist ./ | ||
|
|
||
| # Update version in package.json | ||
| VERSION=$(node -p "require('../package.json').version") | ||
| node -e " | ||
| const pkg = require('./package.json'); | ||
| pkg.version = process.argv[1]; | ||
| require('fs').writeFileSync('package.json', JSON.stringify(pkg, null, 2)); | ||
| " "$VERSION" | ||
|
|
||
| # Commit and tag | ||
| git config user.name github-actions | ||
| git config user.email github-actions@github.com | ||
| git add dist package.json | ||
| git commit -m "Release v$VERSION - build artifacts only" | ||
| git tag v$VERSION | ||
| git push origin master | ||
| git push origin v$VERSION | ||
| publish-build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' | ||
|
|
||
| # Build the library | ||
| - name: Install and Build | ||
| run: | | ||
| npm ci | ||
| npm run build | ||
|
|
||
| # Push to public mirror repo | ||
| - name: Push Build to Public Mirror | ||
| env: | ||
| FORCE_UI_TOKEN: ${{ secrets.FORCE_UI_TOKEN }} | ||
| run: | | ||
| # Clone public mirror repo | ||
| git clone https://x-access-token:${{ secrets.FORCE_UI_TOKEN }}@github.com/brainstormforce/bsf-admin-ui.git build-repo | ||
|
|
||
| cd build-repo | ||
|
|
||
| # Clear old dist | ||
| rm -rf dist | ||
|
|
||
| # Copy new build | ||
| cp -r ../dist ./ | ||
|
|
||
| # Update version in package.json | ||
| VERSION=$(node -p "require('../package.json').version") | ||
| node -e " | ||
| const pkg = require('./package.json'); | ||
| pkg.version = process.argv[1]; | ||
| require('fs').writeFileSync('package.json', JSON.stringify(pkg, null, 2)); | ||
| " "$VERSION" | ||
|
|
||
| # Commit and tag | ||
| git config user.name github-actions | ||
| git config user.email github-actions@github.com | ||
| git add dist package.json | ||
| git commit -m "Release v$VERSION - build artifacts only" | ||
| git tag v$VERSION | ||
| git push origin master | ||
| git push origin v$VERSION |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| name: Publish Package | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@brainstormforce' | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@brainstormforce' | ||
|
|
||
| - run: npm ci | ||
| - run: npm run build | ||
| - run: npm ci | ||
| - run: npm run build | ||
|
|
||
| - run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // This file has been automatically migrated to valid ESM format by Storybook. | ||
| import { fileURLToPath } from "node:url"; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import type { StorybookConfig } from '@storybook/react-vite'; | ||
| import path, { dirname } from 'path'; | ||
|
|
||
|
|
@@ -10,14 +10,14 @@ const __dirname = dirname(__filename); | |
| const config: StorybookConfig = { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What: When specifying the stories in the configuration, consider using constants for patterns if they are referenced multiple times in the codebase in the future. Why: Using constants enhances maintainability and refactorability as any changes to the stories' paths can be applied in a single place instead of multiple occurrences throughout the code. How: Define a constant at the top of the file like |
||
| stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'], | ||
| addons: [ | ||
| '@storybook/addon-onboarding', | ||
| '@storybook/addon-links', | ||
| '@chromatic-com/storybook', | ||
| '@storybook/addon-a11y', | ||
| '@storybook/addon-docs', | ||
| '@storybook/addon-mcp', | ||
| '@storybook/addon-vitest' | ||
| ], | ||
| '@storybook/addon-onboarding', | ||
| '@storybook/addon-links', | ||
| '@chromatic-com/storybook', | ||
| '@storybook/addon-a11y', | ||
| '@storybook/addon-docs', | ||
| '@storybook/addon-mcp', | ||
| '@storybook/addon-vitest', | ||
| ], | ||
| framework: { | ||
| name: '@storybook/react-vite', | ||
| options: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What: The quotation marks in the import statement should be consistent with the rest of the codebase, preferably using double quotes for consistency.
Why: Consistency in code style improves readability and maintainability. In JavaScript and TypeScript, using the same type of quotation marks throughout the code helps avoid confusion and enforces style guidelines.
How: Change the import statement from
import { fileURLToPath } from 'node:url';toimport { fileURLToPath } from "node:url";. This aligns it with the existing style using double quotes.