Release v1.7.12 (signed)#463
Conversation
- feat(textarea): add autoResize, minHeight, and maxHeight props - feat(line-chart): add seriesLabels prop for translatable tooltip series names - feat(datepicker): add opt-in enableTimeSelection prop - fix(editor-input): support Lexical mention menu in Shadow DOM - perf: fix typing lag from always-mounted accordion content and eager typeahead anchor - docs: fix MCP server URL in README, changelog updates - chore: remove unused component-data.json, reformat workflow files and storybook config Squashed from staging to replace PR #460 (unsigned commits blocked merge).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import { fileURLToPath } from "node:url"; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import type { StorybookConfig } from '@storybook/react-vite'; | ||
| import path, { dirname } from 'path'; |
There was a problem hiding this comment.
What: Inconsistent use of quotes for module imports.
Why: Consistency in code styling, including aspects such as quotation marks, not only enhances the readability of the code but also helps maintain a uniform codebase. This makes it easier for developers to navigate and maintain the project, especially when working within teams.
How: Consider standardizing all import statements to use either single quotes or double quotes consistently throughout the file. For instance, changing import { fileURLToPath } from "node:url"; to import { fileURLToPath } from 'node:url'; to match the new style. This aligns with the updated line.
| @@ -10,14 +10,14 @@ const __dirname = dirname(__filename); | |||
| const config: StorybookConfig = { | |||
There was a problem hiding this comment.
What: Possible unnecessary spacing adjustments in the array of addons.
Why: While formatting spacing can often make code easier to read, excessive reformatting or re-spacing can introduce noise into version control history without functional improvements. This can make it difficult to track actual code changes versus mere formatting changes.
How: When editing this section, only modify spacing and alignment where it improves readability and maintainability. If you previously had an organization of entries, consider keeping similar formatting to avoid unnecessary diffs.
| '@storybook/addon-vitest' | ||
| ], | ||
| '@storybook/addon-onboarding', | ||
| '@storybook/addon-links', |
There was a problem hiding this comment.
What: Ensure that all addons in the configuration meet the latest versions and security standards.
Why: Older versions of add-ons might contain vulnerabilities that could be exploited, especially in a development environment where testing is done. Keeping dependencies up-to-date reduces security risks and benefits from performance improvements and new features.
How: Check each addon listed in the config against the latest version available in npm or the project's repository. If there are updates available, consider updating them and testing for any breaking changes that may occur.
| // This file has been automatically migrated to valid ESM format by Storybook. | ||
| import { fileURLToPath } from "node:url"; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import type { StorybookConfig } from '@storybook/react-vite'; |
There was a problem hiding this comment.
What: The import statement style has been switched from double quotes to single quotes for consistency.
Why: Consistency in import statement style helps maintain readability and adheres to common coding standards. It reduces cognitive load for developers reading the code and prevents mixing styles which can lead to confusion.
How: Consider maintaining your project's coding style guide regarding quotes. If standardizing on single quotes is the direction, ensure that this is consistently applied across the entire codebase.
1 participant
Replaces #460, which was blocked from merging because 5 commits lacked verified signatures (
964fdbef,f39d47dc,0348e8c3,6aef2247,f361235e).This branch squashes the full
stagingdiff into a single signed commit. Tree is byte-identical tostaging(git diff origin/staging HEADis empty).Changes in v1.7.12
autoResize,minHeight, andmaxHeightpropsseriesLabelsprop for translatable tooltip series namesenableTimeSelectionpropcomponent-data.json, reformat workflow files and storybook config