Add Helium browser profile path to discovery list#394
Open
tcsenpai wants to merge 1 commit into
Open
Conversation
Helium (https://helium.computer, bundle id net.imput.helium) is a Chromium-based browser on macOS. Its user-data-dir lives at ~/Library/Application Support/net.imput.helium, which was missing from the PROFILES discovery list, so Way 1 (chrome://inspect checkbox) attaches failed with 'DevToolsActivePort not found' even when Helium had remote debugging enabled and was listening on 127.0.0.1:9222.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helium (helium.computer, bundle id
net.imput.helium) is a Chromium-based browser on macOS. Its user-data-dir lives at~/Library/Application Support/net.imput.helium, which was missing fromPROFILESindaemon.py.Without this entry, Way 1 attaches (chrome://inspect/#remote-debugging checkbox) fail with
DevToolsActivePort not found ...even when Helium has remote debugging enabled and is listening on127.0.0.1:9222, because_ws_from_devtools_active_portand the local-discovery loop both iteratePROFILESand can't find Helium'sDevToolsActivePortfile.Test plan
chrome://inspect/#remote-debuggingcheckbox ticked exposes~/Library/Application Support/net.imput.helium/DevToolsActivePortcontaining port9222+ ws path.browser-harnessraisesDevToolsActivePort not found in [...].browser-harness <<< 'print(page_info())'returns the active Helium tab's page info;new_tab(...)+wait_for_load()work end-to-end.Summary by cubic
Add Helium (
net.imput.helium) profile path~/Library/Application Support/net.imput.heliumto the macOS discovery list. This fixes “DevToolsActivePort not found” and allows attaching to Helium via chrome://inspect when remote debugging is enabled.Written for commit c15c5fb. Summary will update on new commits.
Review in cubic