Conversation
🦋 Changeset detectedLatest commit: 91de32e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
stagehand.actsurfacing an HTTP error after Gemini returned a schema-invalid action object with an emptyelementId.NoObjectGeneratedError, but that previously bypassed ActHandler's existingNo action foundresult path.What changed
NoObjectGeneratedErrorat the ActHandler inference boundary usingNoObjectGeneratedError.isInstance(error).success: falseresult, while rethrowing other LLM/provider errors.Testing
NoObjectGeneratedErrorreturningFailed to perform act: No action found.pnpm --filter @browserbasehq/stagehand run test:core -- packages/core/dist/esm/tests/unit/timeout-handlers.test.jsandpnpm --filter @browserbasehq/stagehand run typecheck.Summary by cubic
Prevents HTTP errors when act inference returns no schema-valid action. ActHandler now maps
NoObjectGeneratedErrorto the existing “No action found” result and rethrows other provider errors.NoObjectGeneratedErrorat the ActHandler boundary, log it, and return the “No action found” path instead of surfacing an HTTP error.@browserbasehq/stagehand; non-structured-output errors still reject.Written for commit 91de32e. Summary will update on new commits. Review in cubic