fix(percy): disable runPercyScan#285
Merged
gaurav-singh-9227 merged 1 commit intobrowserstack:mainfrom Apr 27, 2026
Merged
Conversation
ruturaj-browserstack
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runPercyScanwas embedding the server-fetched Percy token in plaintext inside the tool response (export PERCY_TOKEN="<actual_token>").runPercyScanMCP tool registration insrc/tools/percy-sdk.tsso the leaking code path is no longer reachable viatools/list/tools/call.src/tools/run-percy-scan.ts) is untouched — it remains exported and unit-tested. The proper fix (replacing the interpolated token with a placeholder) will land in the planned sprint per Gaurav's note on the ticket.src/tools/sdk-utils/percy-web/handler.ts(called fromexpandPercyVisualTesting). Reporter flagged it under "Code References" in the original H1 submission. Out of scope for this temp fix per Pradum's instruction; should be addressed in the proper-fix PR.Test plan
npm run lintnpx tsc --noEmitnpm test— 122/122 passrunPercyScanno longer appears intools/listfrom a connected MCP client